Avoid catch (Throwable t) in AmazonBedrockStreamingChatProcessor
#115715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
DaveCTurner
added
>bug
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @DaveCTurner, I've created a changelog YAML for you. |
prwhelan
approved these changes
Oct 28, 2024
prwhelan
approved these changes
Oct 28, 2024
| try { | ||
| threadPool.executor(UTILITY_THREAD_POOL_NAME).execute(runnable); | ||
| } catch (Exception e) { | ||
| logger.error(Strings.format("failed to fork [%s] to utility thread pool", runnable), e); |
There was a problem hiding this comment.
We probably should have been handling the exception - I didn't think to do that initially, but seeing it explicitly caught like this is making me think we should
Suggested change
| logger.error(Strings.format("failed to fork [%s] to utility thread pool", runnable), e); | |
| logger.error(Strings.format("failed to fork [%s] to utility thread pool", runnable), e); | |
| cancel(); | |
| onError(e); |
We can either include that here (and I can follow up with a unit test) or I can follow up with that change outside of this one.
There was a problem hiding this comment.
I'll leave that for you to do in a followup. In practice we can't really throw an exception here anyway because of how the UTILITY_THREAD_POOL_NAME executor is configured today.
DaveCTurner
deleted the
2024/10/26/AmazonBedrockStreamingChatProcessor-CompletableFuture
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 28, 2024
…lastic#115715) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Oct 28, 2024
…lastic#115715) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2024
…115715) (#115790) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Oct 28, 2024
…115715) (#115789) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Nov 4, 2024
…lastic#115715) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Nov 4, 2024
…lastic#115715) `CompletableFuture.runAsync` implicitly catches all `Throwable` instances thrown by the task, which includes `Error` instances that no reasonable application should catch. Moreover, discarding the return value from these methods means that any such `Error` will be ignored, allowing the JVM to carry on running in an invalid state. This commit replaces these trappy calls with more appropriate exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompletableFuture.runAsyncimplicitly catches allThrowableinstances thrown by the task, which includes
Errorinstances that noreasonable application should catch. Moreover, discarding the return
value from these methods means that any such
Errorwill be ignored,allowing the JVM to carry on running in an invalid state.
This commit replaces these trappy calls with more appropriate exception
handling.