Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Long balance computation should not delay new index primary assignment #116316

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

pxsalehi
Copy link
Member

@pxsalehi pxsalehi commented Nov 6, 2024

Unfortunately, this didn't backport cleanly.

Relates #115511

elastic#115511)

A long desired balance computation could delay a newly created index shard from being assigned since first the computation has to finish for the assignments to be published and the shards getting assigned. With this change we add a new setting which allows setting a maximum time for a computation in case there are unassigned primary shards. Note that this is similar to how a new cluster state causes early publishing of the desired balance.

Closes ES-9616
@pxsalehi pxsalehi added >non-issue :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) v8.17.0 backport labels Nov 6, 2024
@pxsalehi pxsalehi requested a review from idegtiarenko November 6, 2024 10:50
@pxsalehi
Copy link
Member Author

pxsalehi commented Nov 6, 2024

@elasticmachine update branch
(failures are #102992 and #108628)

@pxsalehi pxsalehi requested a review from nicktindall November 6, 2024 13:15
Copy link
Contributor

@nicktindall nicktindall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pxsalehi
Copy link
Member Author

pxsalehi commented Nov 7, 2024

@elasticmachine update branch

@pxsalehi pxsalehi merged commit 69df7fb into elastic:8.x Nov 7, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants