Refactor usage test to check individual items in response #116418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kderusso
added
>test
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
Samiul-TheSoccerFan
approved these changes
Nov 7, 2024
💚 Backport successful
|
kderusso
added a commit
to kderusso/elasticsearch
that referenced
this pull request
Nov 7, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 7, 2024
kderusso
added a commit
to kderusso/elasticsearch
that referenced
this pull request
Nov 7, 2024
jozala
pushed a commit
that referenced
this pull request
Nov 13, 2024
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors existing usage tests, to check individual items in the
_xpack/usageresponse rather than the entire Json call.This is required as a pre-requisite to adding additional fields to this call - while additive fields are not a breaking change, they will break REST compatibility tests if they match against an entire json block.