Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] ESQL: Fix EsqlNodeSubclassTests (#116496) #116505

Merged

Conversation

alex-spies
Copy link
Contributor

Backports the following commits to 8.x:

- Fix EsqlNodeSubclassTests so that they also test the Node subclasses in esql.core.
- Fix the re-enabled tests for Field-/Reference-/MetadataAttribute by using the
  longest public c'tor in their info() method implementations.
@alex-spies alex-spies added :Analytics/ES|QL AKA ESQL >bug >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Nov 8, 2024
@elasticsearchmachine elasticsearchmachine merged commit 8321277 into elastic:8.x Nov 8, 2024
15 checks passed
@alex-spies alex-spies deleted the backport/8.x/pr-116496 branch November 8, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants