-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for cluster to be green in 40_get_secrets #117217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that fast refresh searches go to search nodes instead of index nodes, the YAML test for `fleet.get_secret` sometimes fails if the shard isn't available yet on the search node before the request arrives. Addresses elasticsearch-serverless elastic#3159, which can unmute the test once this is available.
bcully
added
>test
Issues or PRs that are addressing/adding tests
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
Team:Distributed Indexing
Meta label for Distributed Indexing team
labels
Nov 20, 2024
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
v9.0.0
serverless-linked
Added by automation, don't add manually
labels
Nov 20, 2024
kingherc
reviewed
Nov 21, 2024
.../plugin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/40_secrets_get.yml
Outdated
Show resolved
Hide resolved
kingherc
approved these changes
Nov 21, 2024
.../plugin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/40_secrets_get.yml
Show resolved
Hide resolved
.../plugin/fleet/qa/rest/src/yamlRestTest/resources/rest-api-spec/test/fleet/40_secrets_get.yml
Outdated
Show resolved
Hide resolved
bcully
added a commit
to bcully/elasticsearch
that referenced
this pull request
Nov 21, 2024
Now that fast refresh searches go to search nodes, we need to wait for replicas to be available on them before we hit them. See elastic#117217 for context, it's the same issue.
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Nov 22, 2024
Now that fast refresh searches go to search nodes instead of index nodes, the YAML test for `fleet.get_secret` sometimes fails if the shard isn't available yet on the search node before the request arrives. Addresses elasticsearch-serverless elastic#3159, which can unmute the test once this is available.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
Now that fast refresh searches go to search nodes instead of index nodes, the YAML test for `fleet.get_secret` sometimes fails if the shard isn't available yet on the search node before the request arrives. Addresses elasticsearch-serverless elastic#3159, which can unmute the test once this is available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Engine
Anything around managing Lucene and the Translog in an open shard.
serverless-linked
Added by automation, don't add manually
Team:Distributed Indexing
Meta label for Distributed Indexing team
>test
Issues or PRs that are addressing/adding tests
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that fast refresh searches go to search nodes instead of index nodes, the YAML test for
fleet.get_secret
sometimes fails if the shard isn't available yet on the search node before the request arrives.Addresses elasticsearch-serverless #3159, which can unmute the test once this is available.