Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ChunkingOptions parameter #117235

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ashm-dev
Copy link

Marked ChunkingOptions parameter as @deprecated in multiple methods. Updated method signatures in InferenceService and SenderService classes. No functionality changes, just preparing for future removal.

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

Marked ChunkingOptions parameter as @deprecated in multiple methods.
Updated method signatures in InferenceService and SenderService classes.
No functionality changes, just preparing for future removal.
Copy link

cla-checker-service bot commented Nov 21, 2024

💚 CLA has been signed

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.0.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 21, 2024
@ashm-dev
Copy link
Author

Closes #117193

@ashm-dev
Copy link
Author

Hello! 👋

This is my first PR to the ElasticSearch project, and I’m just starting to learn and explore this amazing system. I’d greatly appreciate any feedback, comments, or suggestions to help improve this PR or my approach to working with ElasticSearch.

Thank you in advance for your time and support!

@gbanasiak gbanasiak added the :ml Machine learning label Nov 22, 2024
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team and removed needs:triage Requires assignment of a team area label labels Nov 22, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :ml Machine learning Team:ML Meta label for the ML team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants