-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Fix Concurrency issue in buildparams access #117552
Merged
breskeby
merged 7 commits into
elastic:main
from
breskeby:fix-concurrency-buildparamsissue
Dec 13, 2024
Merged
[Build] Fix Concurrency issue in buildparams access #117552
breskeby
merged 7 commits into
elastic:main
from
breskeby:fix-concurrency-buildparamsissue
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breskeby
added
>non-issue
:Delivery/Build
Build or test infrastructure
Team:Delivery
Meta label for Delivery team
labels
Nov 26, 2024
Pinging @elastic/es-delivery (Team:Delivery) |
breskeby
added
v8.16.2
v8.17.1
v8.18.0
auto-backport
Automatically create backport pull requests when merged
labels
Nov 26, 2024
Also provide caching support for buildparams provider
breskeby
force-pushed
the
fix-concurrency-buildparamsissue
branch
from
December 12, 2024 21:17
1aed8e6
to
550105b
Compare
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 13, 2024
Also provide caching support for buildparams provider * Extract BuildParameterExtension public api into interface * Make tests better readable * Fix test flakyness
This was referenced Dec 13, 2024
breskeby
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Dec 13, 2024
Also provide caching support for buildparams provider * Extract BuildParameterExtension public api into interface * Make tests better readable * Fix test flakyness
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
backport pending
:Delivery/Build
Build or test infrastructure
>non-issue
Team:Delivery
Meta label for Delivery team
v8.16.3
v8.17.1
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also provide caching support for buildparams provider
Fixes concurrent access to build params provider as seen in https://gradle-enterprise.elastic.co/s/32pmi6kdmvso4