Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Fix Concurrency issue in buildparams access #117552

Merged
merged 7 commits into from
Dec 13, 2024

Conversation

breskeby
Copy link
Contributor

@breskeby breskeby commented Nov 26, 2024

Also provide caching support for buildparams provider

Fixes concurrent access to build params provider as seen in https://gradle-enterprise.elastic.co/s/32pmi6kdmvso4

@breskeby breskeby self-assigned this Nov 26, 2024
@breskeby breskeby requested a review from a team as a code owner November 26, 2024 11:56
@breskeby breskeby added >non-issue :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team labels Nov 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@breskeby breskeby added v8.16.2 v8.17.1 v8.18.0 auto-backport Automatically create backport pull requests when merged labels Nov 26, 2024
@breskeby breskeby marked this pull request as draft November 26, 2024 11:58
@breskeby breskeby marked this pull request as ready for review November 27, 2024 07:18
@breskeby breskeby enabled auto-merge (squash) December 10, 2024 06:52
@breskeby breskeby force-pushed the fix-concurrency-buildparamsissue branch from 1aed8e6 to 550105b Compare December 12, 2024 21:17
@breskeby breskeby disabled auto-merge December 13, 2024 07:55
@breskeby breskeby merged commit 1b4f5eb into elastic:main Dec 13, 2024
2 of 4 checks passed
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Dec 13, 2024
Also provide caching support for buildparams provider
* Extract BuildParameterExtension public api into interface
* Make tests better readable
* Fix test flakyness
breskeby added a commit to breskeby/elasticsearch that referenced this pull request Dec 13, 2024
Also provide caching support for buildparams provider
* Extract BuildParameterExtension public api into interface
* Make tests better readable
* Fix test flakyness
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.17
8.x Commit could not be cherrypicked due to conflicts
8.16

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 117552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged backport pending :Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.16.3 v8.17.1 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants