Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kderusso/sparse vector ci failure #117930

Merged
merged 3 commits into from
Dec 4, 2024
Merged

Kderusso/sparse vector ci failure #117930

merged 3 commits into from
Dec 4, 2024

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Dec 3, 2024

Resolves #117904

@kderusso kderusso added >test-failure Triaged test failures from CI :ml Machine learning :SearchOrg/Relevance Label for the Search (solution/org) Relevance team labels Dec 3, 2024
@kderusso kderusso mentioned this pull request Dec 3, 2024
Closed
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

@kderusso kderusso requested a review from a team December 3, 2024 20:51
Samiul-TheSoccerFan
Samiul-TheSoccerFan approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@Samiul-TheSoccerFan Samiul-TheSoccerFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jimczi
jimczi approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @kderusso

@kderusso kderusso merged commit 97601b1 into elastic:main Dec 4, 2024
2 of 4 checks passed
@kderusso kderusso deleted the kderusso/sparse-vector-ci-failure branch December 4, 2024 13:11
@davidkyle davidkyle mentioned this pull request Dec 4, 2024
Closed
@kderusso kderusso restored the kderusso/sparse-vector-ci-failure branch December 4, 2024 15:32
@kderusso kderusso mentioned this pull request Dec 4, 2024
Merged
kderusso added a commit to kderusso/elasticsearch that referenced this pull request Dec 4, 2024
@kderusso
Kderusso/sparse vector ci failure (elastic#117930)
00bddcb 
* Fix CI failure in SparseVectorQueryBuilderTests

* Unmute test

(cherry picked from commit 97601b1)

# Conflicts:
#	muted-tests.yml
kderusso added a commit to kderusso/elasticsearch that referenced this pull request Dec 4, 2024
@kderusso
Kderusso/sparse vector ci failure (elastic#117930)
f9da887 
* Fix CI failure in SparseVectorQueryBuilderTests
elasticsearchmachine pushed a commit that referenced this pull request Dec 4, 2024
@kderusso
Kderusso/sparse vector ci failure (#117930) (#118014)
4254ca3 
* Fix CI failure in SparseVectorQueryBuilderTests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
:ml Machine learning :SearchOrg/Relevance Label for the Search (solution/org) Relevance team >test-failure Triaged test failures from CI v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] SparseVectorQueryBuilderTests testToQuery failing
4 participants
@kderusso @elasticsearchmachine @jimczi @Samiul-TheSoccerFan