-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connector APIs] Update yaml rest tests for Connector APIs #118260
Merged
jedrazb
merged 3 commits into
elastic:main
from
jedrazb:connector-apis-update-yaml-tests
Dec 13, 2024
Merged
[Connector APIs] Update yaml rest tests for Connector APIs #118260
jedrazb
merged 3 commits into
elastic:main
from
jedrazb:connector-apis-update-yaml-tests
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
added
>non-issue
:SearchOrg/Extract&Transform
Label for the Search E&T team
Team:Search - Extract & Transform
v9.0.0
v8.17.0
v8.18.0
labels
Dec 9, 2024
@elasticmachine merge upstream |
Pinging @elastic/search-eng (Team:SearchOrg) |
elasticsearchmachine
added
the
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
label
Dec 9, 2024
Pinging @elastic/search-extract-and-transform (Team:Search - Extract & Transform) |
...estTest/resources/rest-api-spec/test/entsearch/connector/130_connector_update_index_name.yml
Show resolved
Hide resolved
carlosdelest
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as a pre-req for #117778
jedrazb
added
the
auto-backport
Automatically create backport pull requests when merged
label
Dec 13, 2024
This was referenced Dec 13, 2024
jedrazb
added a commit
to jedrazb/elasticsearch
that referenced
this pull request
Dec 13, 2024
…18260) * [Connector API] Update yaml tests * Update tests --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jedrazb
added a commit
to jedrazb/elasticsearch
that referenced
this pull request
Dec 13, 2024
…18260) * [Connector API] Update yaml tests * Update tests --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 13, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…18260) (elastic#118651) * [Connector API] Update yaml tests * Update tests --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…18260) (elastic#118651) * [Connector API] Update yaml tests * Update tests --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>non-issue
:SearchOrg/Extract&Transform
Label for the Search E&T team
Team:Search - Extract & Transform
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
v8.17.0
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This should complement #117778 PR where we introduce new, not backward compatible index name validation for managed connectors.
This is to fix issues with backward compatible rest tests - as was suggested in #elasticsearch slack thread.
Relates to
[Search Connectors] introduce "content-*" prefix requirement for Elastic-managed connectors
dev issue that got green light from bcc.