Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert some ILM classes to records #118466

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

joegallo
Copy link
Contributor

There's a handful of classes in /ilm/ directories that can actually just be records, so I've converted them here.

This is just another cleanup PR along the lines of #118338, I'm working in some ILM code and while I'm here I'm fixing things that I notice.

@joegallo joegallo added >refactoring :Data Management/ILM+SLM Index and Snapshot lifecycle management Team:Data Management Meta label for data/management team v9.0.0 v8.18.0 labels Dec 11, 2024
@joegallo joegallo requested a review from nielsbauman December 11, 2024 14:50
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@joegallo joegallo added the auto-backport Automatically create backport pull requests when merged label Dec 11, 2024
Copy link
Contributor

@nielsbauman nielsbauman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Joe!

@joegallo joegallo merged commit 9056fe4 into elastic:main Dec 11, 2024
16 checks passed
@joegallo joegallo deleted the ilm-classes-to-records branch December 11, 2024 20:54
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.x

joegallo added a commit to joegallo/elasticsearch that referenced this pull request Dec 11, 2024
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
maxhniebergall pushed a commit to maxhniebergall/elasticsearch that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/ILM+SLM Index and Snapshot lifecycle management >refactoring Team:Data Management Meta label for data/management team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants