ESQL: tests for LOOKUP JOIN with non-unique join keys #118471
Merged
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-spies
commented
Dec 11, 2024
Comment on lines
+3
to
+4
| 1,English, | ||
| 1,,United Kingdom |
There was a problem hiding this comment.
Adding some intentional denormalization ("dirty data") to show how we're collecting nulls and mvs.
alex-spies
added
>test
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
approved these changes
Dec 11, 2024
| @@ -3,7 +3,6 @@ | |||
| // Reuses the sample dataset and commands from enrich.csv-spec | |||
| // | |||
|
|
|||
| //TODO: this sometimes returns null instead of the looked up value (likely related to the execution order) | |||
There was a problem hiding this comment.
I removed this in my PR too!
x-pack/plugin/esql/qa/testFixtures/src/main/resources/lookup-join.csv-spec
Outdated
Show resolved
Hide resolved
idegtiarenko
approved these changes
Dec 12, 2024
Just after the tests with the languages_lookup index, for better organization of the tests.
alex-spies
added
the
auto-merge-without-approval
💚 Backport successful
|
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Dec 13, 2024
Add a csv dataset and tests for `LOOKUP JOIN` where the join keys are not unique. In particular, add tests that include MVs and nulls to see how `LOOKUP JOIN` treats these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a csv dataset and tests for
LOOKUP JOINwhere the join keys are not unique. In particular, add tests that include MVs and nulls to see howLOOKUP JOINtreats these.