Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inference API] Replace ElasticsearchTimeoutException with ElasticsearchStatusException #118618

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

maxhniebergall
Copy link
Member

@maxhniebergall maxhniebergall commented Dec 12, 2024

... with 408 status to avoid causing 503s.

Closes #112828 (comment)

@elasticsearchmachine elasticsearchmachine added the Team:ML Meta label for the ML team label Dec 12, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ;)

Comment on lines +68 to +71
new ElasticsearchStatusException(
Strings.format("Request timed out waiting to be sent after [%s]", timeout),
RestStatus.REQUEST_TIMEOUT
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@maxhniebergall maxhniebergall enabled auto-merge (squash) December 12, 2024 21:31
@maxhniebergall maxhniebergall merged commit 44a231a into main Dec 13, 2024
17 checks passed
@maxhniebergall maxhniebergall deleted the changeException branch December 13, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inference request task timeout should not be 503
5 participants