Add undeclared Azure settings, modify test to exercise them #118634
Merged
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktindall
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
I added tests that two of the settings are effective when set, the remaining ones don't seem to be easily testable |
ywangd
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
LGTM
I think this should be labelled as >bug instead? It has a visible impact and also could use a doc update.
Being able to registering all these settings is already a test. So I am not too worried about testing whether the remaining two getting picked up by the connectionProvider.
| ThreadPool nodeThreadPool = internalCluster().getInstance(ThreadPool.class); | ||
| assertEquals( | ||
| EVENT_LOOP_THREAD_COUNT_SETTING.get(), | ||
| ((EsThreadPoolExecutor) nodeThreadPool.executor(AzureRepositoryPlugin.NETTY_EVENT_LOOP_THREAD_POOL_NAME)).getMaximumPoolSize() |
There was a problem hiding this comment.
Nit: can this be
nodeThreadPool.info(AzureRepositoryPlugin.NETTY_EVENT_LOOP_THREAD_POOL_NAME).max()
?
There was a problem hiding this comment.
Yes, that's much nicer, thanks. Used in a0eaa92
|
Hi @nicktindall, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declares some settings that were undeclared by the Azure repository plugin.
Specifically, this PR allows use of
repository.azure.http_client.event_loop_executor_thread_countrepository.azure.http_client.max_open_connectionsrepository.azure.http_client.connection_timeoutrepository.azure.http_client.connection_max_idle_time