Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.17] Fix bug in InferenceUpgradeTestCase.getConfigsWithBreakingChangeHandling (#118624) #118663

Merged

Conversation

original-brownbear
Copy link
Member

Backports the following commits to 8.17:

…ing (elastic#118624)

We need to load the two fields from the same response. Otherwise, we can have a sort of race
where we load "endpoints" from pre-8.15 as empty and then load "models" from a post-8.15 node
also empty, resulting in an empty list because we took the wrong info from either response.

closes elastic#118163
@original-brownbear original-brownbear added :ml Machine learning >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:ML Meta label for the ML team labels Dec 13, 2024
@elasticsearchmachine elasticsearchmachine merged commit 3f15846 into elastic:8.17 Dec 13, 2024
15 checks passed
@original-brownbear original-brownbear deleted the backport/8.17/pr-118624 branch December 13, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.17.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants