[test] Avoid running the NoImds test on AWS #118675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled the NoImds test on AWS EC2 instance where it fails because the AWS metadata are available, which is not expected by this test.
jozala
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@DaveCTurner is this reasonable, or would you prefer the fixture be updated so that even when real EC2 metadata is present, the test can run? |
|
Ah, I missed that David is on vacation. I think it's okay to merge as-is for now. |
brianseeders
approved these changes
Dec 13, 2024
💚 Backport successful
|
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Dec 13, 2024
Disabled the NoImds test on AWS EC2 instance where it fails because the AWS metadata are available, which is not expected by this test.
|
looks reasonable to me, I see failures in AWS only |
jozala
added a commit
to jozala/elasticsearch
that referenced
this pull request
Dec 16, 2024
Disabled the NoImds test on AWS EC2 instance where it fails because the AWS metadata are available, which is not expected by this test.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 16, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
…#118688) Disabled the NoImds test on AWS EC2 instance where it fails because the AWS metadata are available, which is not expected by this test.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Dec 17, 2024
This test asserts that no AZ attribute is set, assuming that the current AZ is unavailable, but in fact that's not true when running these tests in EC2. With this commit we override the IMDS endpoint address to one that definitely does not exist. Relates elastic#118675 Closes elastic#118564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled the NoImds test on AWS EC2 instance where it fails because the AWS metadata are available, which is not expected by this test.