Refactor semantic text field to align with text field behaviour #119183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the original field
…tic text format selection (#119070) This change replaces the system property used for enabling the new semantic text format with a dedicated index setting resolved at index creation. The new format is tied to the index version, so this approach ensures that indices created with the new version but using the legacy format retain their original configuration. By sealing the format at index creation, we prevent unexpected changes and provide flexibility in tests to explicitly choose the desired format for execution.
jimczi
added
>enhancement
:SearchOrg/Relevance
|
Documentation preview: |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
|
Hi @jimczi, I've created a changelog YAML for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the semantic text field to function similarly to a standard text field. The original source content is preserved, while embedding chunks are retrieved from:
The new format is not enabled by default. An internal index setting is used to enable the new format, allowing for a controlled transition. The switch to the new format will be implemented in a subsequent PR.
Highlighting support is also missing (for the new format) and will be added in a follow up.
Note: Individual commits were reviewed in the original branch for clarity.
This PR is intended for merging rather than detailed review.