Flatten SearchService and clean up build-in registration #12807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is basically a proof of concept for #12783 - it's not just possible this is also much cleaner than the nested module mess we had before. Classes are registered where they belong etc. without unnecessary indirections. |
|
This looks great! +1 |
s1monw
force-pushed
the
flatten_search_service
branch
from
a36fd5b
to
f72a92e
Compare
s1monw
force-pushed
the
flatten_search_service
branch
from
f72a92e
to
6316718
Compare
s1monw
added a commit
that referenced
this pull request
Aug 12, 2015
Flatten SearchService and clean up build-in registration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12783