Simplify custom repository type setup #12948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom repository types are registered through the RepositoriesModule. Later, when a specific repository type is used, the RespositoryModule is installed, which in turn would spawn the module that was registered for that repository type. However, a module is not needed here. Each repository type has two associated classes, a Repository and an IndexShardRepository. This change makes the registration method for custom repository types take both of these classes, instead of a module. See elastic#12783.
rjernst
changed the title
|
LGTM. I like how this removes one level of indirection in the modules. |
| */ | ||
| public Class<? extends Module> type(String type) { | ||
| return repositoryTypes.get(type); | ||
| public void bindType(Binder binder, String type) { |
There was a problem hiding this comment.
Can you add javadocs to bindType and registerRepository?
rjernst
added a commit
that referenced
this pull request
Aug 18, 2015
Simplify custom repository type setup
rjernst
added a commit
that referenced
this pull request
Aug 19, 2015
Custom repository types are registered through the RepositoriesModule. Later, when a specific repository type is used, the RespositoryModule is installed, which in turn would spawn the module that was registered for that repository type. However, a module is not needed here. Each repository type has two associated classes, a Repository and an IndexShardRepository. This change makes the registration method for custom repository types take both of these classes, instead of a module. See #12783. Backport of #12948.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom repository types are registered through the RepositoriesModule.
Later, when a specific repository type is used, the RespositoryModule
is installed, which in turn would spawn the module that was
registered for that repository type. However, a module is not needed
here. Each repository type has two associated classes, a Repository and
an IndexShardRepository.
This change makes the registration method for custom repository
types take both of these classes, instead of a module.
See #12783.