Remove SpawnModules #13034
Merged
Remove SpawnModules #13034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last use case of spawn modules was for plugins. This change handles plugin modules directly, and removes SpawnModules. closes elastic#12783
|
I synced up with master, and also removed PreProcessModule as it is no longer used. |
| @@ -316,6 +333,11 @@ public synchronized IndexService createIndex(String sIndexName, @IndexSettings S | |||
| modules.add(new IndexAliasesServiceModule()); | |||
| modules.add(new IndexModule(indexSettings)); | |||
|
|
|||
| for (Module pluginModule : pluginsService.indexModules(indexSettings)) { | |||
There was a problem hiding this comment.
is this actually used anywhere? I mean why would you add your own index modules? I really wonder if we need this kind of extension mechanism? I know it's unrelated but maybe we need a followup issue?
|
LGTM |
|
@rjernst Did you mean to merge this in to 2.0 as well? |
s1monw
pushed a commit
to s1monw/elasticsearch
that referenced
this pull request
Aug 25, 2015
Remove SpawnModules
|
back-ported to 2.0 branch as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last use case of spawn modules was for plugins. This change handles
plugin modules directly, and removes SpawnModules.
closes #12783