Add plugin modules before (almost all) others #13061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes modules added by plugins come before others, as it was before elastic#12783. The order of configuration, and thereby binding, happens in the order modules are received, and without this change, some plugins can get *insane* guice errors (500mb stack trace).
|
LGTM thanks! |
rjernst
added a commit
that referenced
this pull request
Aug 23, 2015
Add plugin modules before (almost all) others
rjernst
added a commit
that referenced
this pull request
Aug 23, 2015
s1monw
pushed a commit
to s1monw/elasticsearch
that referenced
this pull request
Aug 25, 2015
Add plugin modules before (almost all) others
s1monw
pushed a commit
to s1monw/elasticsearch
that referenced
this pull request
Aug 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes modules added by plugins come before others, as it was
before #12783. The order of configuration, and thereby binding, happens
in the order modules are received, and without this change, some plugins
can get insane guice errors (500mb stack trace).