Add readonly option for repositories
#13144
Conversation
imotov
added
>enhancement
review
:Distributed Coordination/Snapshot/Restore
| @@ -121,6 +121,7 @@ The following settings are supported: | |||
| using size value notation, i.e. 1g, 10m, 5k. Defaults to `null` (unlimited chunk size). | |||
| `max_restore_bytes_per_sec`:: Throttles per node restore rate. Defaults to `40mb` per second. | |||
| `max_snapshot_bytes_per_sec`:: Throttles per node snapshot rate. Defaults to `40mb` per second. | |||
| `readonly`:: Makes repository read-only. Defaults to `false`. | |||
There was a problem hiding this comment.
The only concern I have is about the documentation but it's not exactly related to this change.
For example, the new option readonly only appears within Shared FS repository although it will be a "common" option to many repositories.
Should we rewrite this part of the doc?
|
It looks good to me. Side question: wondering in the future if we can imagine a way to snapshot (write) over HTTP so have writeable URL repositories? |
|
@dadoonet URL repository is ignoring this flag. So, it still cannot write anything even if you set readonly to true for it. So, it's not a common option in a sense. So, maybe, I should add it to other repos that support it (s3, azure). What do you think? |
++ |
Closes elastic#7831 Closes elastic#11753
imotov
force-pushed
the
issue-11753-readonly-repo
branch
from
072323d
to
2b87d7d
Compare
Closes #7831
Closes #11753