Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-binary gender option in term aggr. example #19188

Merged
merged 2 commits into from
Jul 1, 2016
Merged

non-binary gender option in term aggr. example #19188

merged 2 commits into from
Jul 1, 2016

Conversation

selfawaresoup
Copy link

@selfawaresoup selfawaresoup commented Jun 30, 2016

Include ar least an 'other' category in the gender example for terms aggregations.

@selfawaresoup
Copy link
Author

I have singed the CLA. Is there a way to re-check it?

@clintongormley clintongormley added the >docs General docs changes label Jun 30, 2016
@clintongormley
Copy link
Contributor

Hi @lnwdr

Thanks for the PR. The change concerns me because it could easily be interpreted to mean that terms aggs now support an automatic other bucket, a much requested feature (see #12411).

Given that this change doesn't add clarity (and actually introduces some confusion) I'm going to close it. Thanks anyway

@clintongormley
Copy link
Contributor

If you'd like to update the PR using a name other than other, then I'd be happy to merge it.

@s1monw
Copy link
Contributor

s1monw commented Jun 30, 2016

@lnwdr another option is to change the example altogether something that is non gender? I mean we can use something like genre and we use rock, folk, electronic etc for the values? WDYT

@selfawaresoup
Copy link
Author

selfawaresoup commented Jun 30, 2016

@clintongormley fair point. @s1monw's suggestion of using music genres is probably the way to go here since alternative terms to 'other' in a gender context would probably have the same problem. I'll update the PR accordingly, if that's ok.

@s1monw
Copy link
Contributor

s1monw commented Jun 30, 2016

@clintongormley fair point. @s1monw's suggestion of using music genres is probably the way to got here since alternative terms to 'other' in a gender context would probably also have the same problem. I'll update the PR accordingly, if that's ok.

++ thanks

@clintongormley
Copy link
Contributor

LGTM, thanks @lnwdr

@clintongormley clintongormley merged commit 6321ff1 into elastic:2.3 Jul 1, 2016
clintongormley pushed a commit that referenced this pull request Jul 1, 2016
* non-binary gender option in term aggr. example

* replace gender with music genre for term aggregation docs
clintongormley pushed a commit that referenced this pull request Jul 1, 2016
* non-binary gender option in term aggr. example

* replace gender with music genre for term aggregation docs
@selfawaresoup selfawaresoup deleted the patch-1 branch July 7, 2016 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes feedback_needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants