-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-binary gender option in term aggr. example #19188
Conversation
I have singed the CLA. Is there a way to re-check it? |
Hi @lnwdr Thanks for the PR. The change concerns me because it could easily be interpreted to mean that terms aggs now support an automatic Given that this change doesn't add clarity (and actually introduces some confusion) I'm going to close it. Thanks anyway |
If you'd like to update the PR using a name other than |
@lnwdr another option is to change the example altogether something that is non gender? I mean we can use something like |
@clintongormley fair point. @s1monw's suggestion of using music genres is probably the way to go here since alternative terms to 'other' in a gender context would probably have the same problem. I'll update the PR accordingly, if that's ok. |
++ thanks |
LGTM, thanks @lnwdr |
* non-binary gender option in term aggr. example * replace gender with music genre for term aggregation docs
* non-binary gender option in term aggr. example * replace gender with music genre for term aggregation docs
Include ar least an 'other' category in the gender example for terms aggregations.