Simplify TcpTransport interface by reducing send code to a single send method #19223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
added
>enhancement
review
:Distributed/Network
|
@jasontedor can you take a look |
| offset += reference.length(); | ||
| ramBytesUsed += reference.ramBytesUsed(); | ||
| } | ||
| this.ramBytesUsed = ramBytesUsed + Integer.BYTES * offsets.length; |
There was a problem hiding this comment.
Plus the object references in BytesReference[], plus the length field, plus the ramBytesUsed field?
|
It looks good @s1monw; I left some minor comments. |
|
@jasontedor I pushed updates |
| @@ -62,7 +62,6 @@ | |||
|
|
|||
| @ClusterScope(scope = Scope.TEST, numDataNodes = 0) | |||
| @ESIntegTestCase.SuppressLocalMode | |||
| @TestLogging("_root:DEBUG,cluster.service:TRACE,discovery.zen:TRACE") | |||
There was a problem hiding this comment.
I'm not sure why this is being removed; can we keep it?
There was a problem hiding this comment.
it's pretty usless if you have that on a test forever? can we add it back when we need it?
|
It still looks good, I left a couple more minor comments. |
…d method Due to some optimization on the netty layer we hade quite some code / cruft added to the TcpTransport to allow for those optimizations. After cleaning up BytesReference we can now move this optimization into TcpTransport and have a simple send method on the implemenation layer instead. This commit adds a CompositeBytesReference that also allows message headers to be written seperately which simplify the header code as well since no skips are needed anymore.
jasontedor
added a commit
that referenced
this pull request
Jul 6, 2016
* master: (192 commits) [TEST] Fix rare OBOE in AbstractBytesReferenceTestCase Reindex from remote Rename writeThrowable to writeException Start transport client round-robin randomly Reword Refresh API reference (#19270) Update fielddata.asciidoc Fix stored_fields message Add missing footer notes in mapper size docs Remote BucketStreams Add doc values support to the _size field in the mapper-size plugin Bump version to 5.0.0-alpha5. Update refresh.asciidoc Update shrink-index.asciidoc Change Debian repository for Vagrant debian-8 box [TEST] fix test to account for internal empyt reference optimization Upgrade to netty 3.10.6.Final (#19235) [TEST] fix histogram test when extended bounds overlaps data Remove redundant modifier Simplify TcpTransport interface by reducing send code to a single send method (#19223) Fix style violation in InstallPluginCommand.java ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to some optimization on the netty layer we had quite some code / cruft
added to the TcpTransport to allow for those optimizations. After cleaning
up BytesReference we can now move this optimization into TcpTransport and
have a simple send method on the implementation layer instead. This commit
adds a CompositeBytesReference that also allows message headers to be written
separately which simplify the header code as well since no skips are needed
anymore.