Introduce Netty 4 #19526
Merged
Introduce Netty 4 #19526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
review
:Distributed/Network
|
The full top-level No attempts have been made to optimize, this can happen in follow ups. Further, no attempts have been made to eliminate any code duplication between transport-netty3 and transport-netty4. Only one of these implementations is going to survive, we shouldn't bind them together to only unbind them later when we kill one of the implementations. |
This was referenced Jul 21, 2016
| if (SETTING_CORS_ALLOW_CREDENTIALS.get(settings)) { | ||
| builder.allowCredentials(); | ||
| } | ||
| String[] strMethods = settings.getAsArray(SETTING_CORS_ALLOW_METHODS.getKey()); |
|
I did one pass, didn't look too close to the http impls maybe @spinscale can look at pipelining and cors etc. |
|
@s1monw Thanks. I've responded to your first round of feedback. |
| @Override | ||
| protected Object decode(ChannelHandlerContext ctx, Channel channel, ChannelBuffer buffer) throws Exception { | ||
| try { | ||
| boolean continueProcessing = TcpTransport.validateMessageHeader(Netty3Utils.toBytesReference(buffer)); | ||
| boolean continueProcessing = transport.validateMessageHeader(buffer); |
There was a problem hiding this comment.
this should also be a static method aagain I guess
Today when an exception occurs on the transport layer, an exception bubbles up where it is caught in the Netty layer and wrapped in Netty-specific exceptions. These exceptions must be unwrapped to be pushed back down to the transport layer for handling. This commit cleans up this unwrapping in the Netty 4 module.
This commit updates the SHAs for the Netty 4 dependencies to the SHAs for the 20160721-*-6 snapshots.
This commit renames the TransportServiceAdapter#received and TransportServiceAdapter#sent interface methods for clarity, and clarifies the usage in Netty4MessageChannelHandler.
This commit improves the handling of resources in the Netty 4 networking implementation.
To determine if we want to close a connection on completion of a request, we need compare the value of the connection header to the string "keep-alive" when the connection is an HTTP 1.0 connection. However, the conditional under question here uses the unary not operator which can sometimes be tricky to see, especially in long expressions. This commit replaces the uses of the unary not operator with comparison to false.
Today we initialize the params field for an instance of Netty4HttpRequest in its constructor. It might be simpler to just initialize the field directly, so that's what we do in this commit.
The base REST request implementation RestRequest defines some abstract methods that are just duplicated across the implementations of the inheriting classes. This commit moves these duplicated impelementations to the base class for simplification.
This commit marks Netty 3 as the default transport client networking implementation, for now.
On the transport layer when decoding the header, we catch and silently swallow and IllegalStateException. This is because this state naturally arises when we have fully consumed the incoming byte buffer. This commit adds a comment explaining this situation.
This commit fixes a broken test case in BytesRestResponseTests that was broken by an earlier refactoring.
This commit addresses a resource leak in the Netty 4 module that arises when the content of a request is held on to after the request has completed.
This commit updates the SHAs for the Netty 4 dependencies to the SHAs for the 20160721-*-7 snapshots.
This commit fixes an NPE that arises in the retry tests due to the ordering of the setup methods.
This commit modifes the Netty 4 build so that the packaged REST tests are run with the Netty 4 module integration tests.
This commit reverts changes to size header frame decoding to keep the API simple, for now.
This commit modifies the Netty 4 dependencies to use Elastic-built artifacts until an official release of Netty 4.1.4.Final+ is made. This is so that we can rely on a stable artifact in the CI environment.
This commit renames a lambda future variable from future1 to f because it's cleaner that way.
This commit clarifies the conversion from BytesReference to CompositeBuffer in Netty4Utils, and provides a safer conversion.
This commit updates the SHAs for the Netty 4 dependencies to the SHAs for the elastic-20160722-*-7 snapshots.
This commit adds netty.assert.buglevel as an additional setting in the client.
This commit reverts the renaming of client:transport back from client:transport-netty.
This commit preserves headers from the thread context on Netty 4 HTTP responses.
|
@jasontedor if you want I can have a look at your netty related code |
|
@normanmaurer Sure! Note there's still a lot of work left to do here, but any feedback is welcome and appreciated. I'm on vacation starting today until August 1, so I won't read/reply until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds transport-netty4, a transport and HTTP implementation
based on Netty 4.
Closes #3226