Make action.auto_create_index setting a dynamic cluster setting
#20274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
added
>enhancement
review
:Core/Infra/Settings
| .metaData(metaData).build(); | ||
| } | ||
|
|
||
| private AutoCreateIndex createAutoCreateIndex(Settings settings) { |
There was a problem hiding this comment.
the double 'create' in the method name confused me a bit when reading it, maybe rename to 'newAutoCreateIndex'?
|
I left some comments. |
martijnvg
force-pushed
the
make_auto_create_index_setting_dynamic
branch
from
0a0cbef
to
64c713d
Compare
|
@jpountz Thanks! I've updated the PR. |
|
LGTM |
martijnvg
force-pushed
the
make_auto_create_index_setting_dynamic
branch
from
64c713d
to
a110498
Compare
ppf2
added a commit
that referenced
this pull request
Oct 16, 2017
Per #20274, action.auto_create_index can be set as a dynamic cluster setting.
nik9000
pushed a commit
that referenced
this pull request
Oct 17, 2017
) Per #20274, action.auto_create_index can be set as a dynamic cluster setting.
nik9000
pushed a commit
that referenced
this pull request
Oct 17, 2017
) Per #20274, action.auto_create_index can be set as a dynamic cluster setting.
nik9000
pushed a commit
that referenced
this pull request
Oct 17, 2017
) Per #20274, action.auto_create_index can be set as a dynamic cluster setting.
GlenRSmith
added a commit
that referenced
this pull request
Jun 7, 2018
This could be ported to any version [since 5.0](#20274)
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 27, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in elastic#20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates elastic#7513
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
DaveCTurner
added a commit
that referenced
this pull request
Jan 28, 2019
We changed the `action.auto_create_index` setting to be a dynamic cluster-level setting in #20274 but today the reference manual indicates that it is still a static node-level setting. This commit addresses this, and clarifies the semantics of patterns that may both permit and forbid the creation of certain indices. Relates #7513, #27026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #7513