add ignore_missing option to SplitProcessor
#20982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talevy
added
>enhancement
:Data Management/Ingest Node
martijnvg
approved these changes
Oct 18, 2016
| @@ -23,6 +23,7 @@ | |||
| import org.elasticsearch.ingest.ConfigurationUtils; | |||
| import org.elasticsearch.ingest.IngestDocument; | |||
| import org.elasticsearch.ingest.Processor; | |||
| import org.jcodings.Config; | |||
| if (oldVal == null) { | ||
| String oldVal; | ||
|
|
||
| try { |
There was a problem hiding this comment.
Maybe we should replace this try-catch block with the a new helper method in IngestDocument?
public <T> T getFieldValue(String path, Class<T> clazz, boolean ignoreMissing) {
try {
return getFieldValue(path, clazz);
} catch (IllegalArgumentException e) {
if (ignoreMissing) {
return null;
} else {
throw e;
}
}
}Not sure about it, but it would save some code repetition in other processors too.
s1monw
reviewed
Oct 18, 2016
| @@ -39,6 +39,7 @@ public void testCreate() throws Exception { | |||
| assertThat(splitProcessor.getTag(), equalTo(processorTag)); | |||
| assertThat(splitProcessor.getField(), equalTo("field1")); | |||
| assertThat(splitProcessor.getSeparator(), equalTo("\\.")); | |||
| assertThat(splitProcessor.isIgnoreMissing(), equalTo(false)); | |||
|
@martijnvg mind giving this another look? |
talevy
added a commit
that referenced
this pull request
Nov 16, 2016
jasontedor
added a commit
that referenced
this pull request
Nov 16, 2016
* master: (22 commits) Add proper toString() method to UpdateTask (#21582) Fix `InternalEngine#isThrottled` to not always return `false`. (#21592) add `ignore_missing` option to SplitProcessor (#20982) fix trace_match behavior for when there is only one grok pattern (#21413) Remove dead code from GetResponse.java Fixes date range query using epoch with timezone (#21542) Do not cache term queries. (#21566) Updated dynamic mapper section Docs: Clarify date_histogram bucket sizes for DST time zones Handle release of 5.0.1 Fix skip reason for stats API parameters test Reduce skip version for stats API parameter tests Strict level parsing for indices stats Remove cluster update task when task times out (#21578) [DOCS] Mention "all-fields" mode doesn't search across nested documents InternalTestCluster: when restarting a node we should validate the cluster is formed via the node we just restarted Fixed bad asciidoc in boolean mapping docs Fixed bad asciidoc ID in node stats Be strict when parsing values searching for booleans (#21555) Fix time zone rounding edge case for DST overlaps ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the additional
ignore_missingparam that was added to many of the processors from: #19995.When option is
true,null-valued and non-existent fields will not result in a thrown exception.Closes #20840.