Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed references to Multi Index Syntax #26956

Closed
wants to merge 1 commit into from
Closed

Fixed references to Multi Index Syntax #26956

wants to merge 1 commit into from

Conversation

shubham391
Copy link
Contributor

No description provided.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@sunkuet02
Copy link
Contributor

sunkuet02 commented Oct 11, 2017

I think, doc is fine in master branch. This PR should be close.

@shubham391
Copy link
Contributor Author

shubham391 commented Oct 11, 2017

@sunkuet02 It is not. The change (if accepted) should be applied in master as well. Maybe you should check once before downvoting.

@sunkuet02
Copy link
Contributor

sunkuet02 commented Oct 11, 2017

@shubham391 Sorry, if I hurt you. Please check the links :

  1. https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-snapshots.html
  2. https://www.elastic.co/guide/en/elasticsearch/reference/master/search-search.html#search-multi-index-type

Make sure, your changes work. Did you check by generating html from asciidoc ?

@shubham391 shubham391 changed the base branch from 5.0 to master October 18, 2017 20:58
@karmi
Copy link
Contributor

karmi commented Oct 18, 2017

Hi @shubham391, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@shubham391 shubham391 changed the base branch from master to 5.0 October 18, 2017 20:59
@shubham391
Copy link
Contributor Author

@karmi The email address in the commit is provided by Github (due to the privacy option enabled on my account). I'm not sure if I can add it to the profile as such (got an error while trying to do so). I have now disabled the privacy option so at least one of the email will be visible to you. Or if there's any other way to validate, please let me know.

@karmi
Copy link
Contributor

karmi commented Oct 25, 2017

Hi @shubham391, you don't have to make the e-mail with which you have signed the CLA public at Github, just add it to your Github account and that should be enough for us to match it with your Github profile.

@javanna javanna changed the base branch from 5.0 to master November 6, 2017 17:08
@javanna javanna changed the base branch from master to 5.6 November 6, 2017 17:08
@javanna javanna changed the base branch from 5.6 to 5.0 November 6, 2017 17:08
@javanna
Copy link
Member

javanna commented Nov 6, 2017

hi @shubham391 your change is good and we do need it also in master. Thanks for sending a PR! The 5.0 branch is no longer under active development though, could you please send this PR against master instead? Thank you! I am closing this as we won't merge it in 5.0.

@javanna javanna closed this Nov 6, 2017
@shubham391 shubham391 deleted the patch-1 branch November 6, 2017 17:18
@shubham391
Copy link
Contributor Author

@javanna Thanks. Created a PR against master: #27283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants