-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed references to Multi Index Syntax #26956
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
I think, doc is fine in master branch. This PR should be close. |
@sunkuet02 It is not. The change (if accepted) should be applied in master as well. Maybe you should check once before downvoting. |
@shubham391 Sorry, if I hurt you. Please check the links :
Make sure, your changes work. Did you check by generating html from asciidoc ? |
Hi @shubham391, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
@karmi The email address in the commit is provided by Github (due to the privacy option enabled on my account). I'm not sure if I can add it to the profile as such (got an error while trying to do so). I have now disabled the privacy option so at least one of the email will be visible to you. Or if there's any other way to validate, please let me know. |
Hi @shubham391, you don't have to make the e-mail with which you have signed the CLA public at Github, just add it to your Github account and that should be enough for us to match it with your Github profile. |
hi @shubham391 your change is good and we do need it also in master. Thanks for sending a PR! The 5.0 branch is no longer under active development though, could you please send this PR against master instead? Thank you! I am closing this as we won't merge it in 5.0. |
No description provided.