Render sum as zero if count is zero for stats aggregation #27193
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
Jenkins test this |
|
jenkins retest this |
|
@liketic There were some issues with the build that were unrelated to your change yesterday that stopped the build from succeeding. These should be fixed now so I'll set off a build again |
|
jenkins test this |
liketic
force-pushed
the
bugfix/issues/26893
branch
from
b543ae5 to
e7a32c6
Compare
|
hi @colings86 I rebased the PR, please try again. Thanks! |
|
jenkins retest this please |
|
@liketic this change looks good to me and the build is now passing. I'll merge this soon. Thanks for the contribution, it is much appreciated |
* master: Fixed byte buffer leak in Netty4 request handler Avoid uid creation in ParsedDocument (#27241) Rander sum as zero if count is zero for stats aggregation (#26893) (#27193) Add additional explanations around discovery.zen.ping_timeout (#27231) Remove unused searcher parameter in SearchService#createContext (#27227) Upgrade to Lucene 7.1 (#27225) Move IndexShard#getWritingBytes() under InternalEngine (#27209) Adjust bwc version for exists query tests Introducing took time for _msearch
clintongormley
changed the title
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Relates: elastic/elasticsearch#27193 This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.
Relates: elastic/elasticsearch#27193 This commit updates Sum property on StatsAggregate to be modelled as non-nullable and to derive ExtendedStatsAggregate from StatsAggregate. Adds integration test to assert deserialization behaviour.
Closes #26893
I would appreciate it if your can take a look at this. @colings86 😃