-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setting index.optimize_auto_generated_id (#27583) #27600
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty sure this is not enough. This setting can be on indices created in 6.x and we will support them in 7.x.
@jasontedor why can't we remove it? it will just be archived since you never pushed #26995 maybe I miss something |
@elasticmachine ok to test |
Thanks for your review. I can address @jasontedor 's comments by deprecating the setting |
Hi @jasontedor Shall I update the PR by deprecating the setting? 👍 Thanks very much! |
@liketic Yes, here is what we need to do:
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Thanks @jasontedor . I opened #28862 for the first one. |
And #28895 for the second one. |
@jasontedor Please review again. |
@elasticmachine test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @liketic. |
Closes #27583