[Test] Fix IndicesClientDocumentationIT #27899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last operation executed in IndicesClientDocumentationIT.testCreate() is an asynchronous index creation. Because nothing waits for its completion, on slow machines the index can sometimes be created after the testCreate() test is finished, and it can fail the following test. Closes elastic#27754
tlrx
added
:Java High Level REST Client
>test
dnhatn
reviewed
Dec 19, 2017
| @@ -188,6 +216,13 @@ public void onFailure(Exception e) { | |||
| } | |||
| }); | |||
| // end::create-index-execute-async | |||
|
|
|||
| assertBusy(() -> { | |||
| // TODO Use Indices Exist API instead once it exists | |||
There was a problem hiding this comment.
Can we use CountDownLatch instead of assertBusy
There was a problem hiding this comment.
I don't think we can because the CountDownLatch will appear in the documentation (everything between // tag::foo and // end::foo is copied in the documentation)
tlrx
added a commit
that referenced
this pull request
Dec 20, 2017
The last operation executed in IndicesClientDocumentationIT.testCreate() is an asynchronous index creation. Because nothing waits for its completion, on slow machines the index can sometimes be created after the testCreate() test is finished, and it can fail the following test. Closes #27754
tlrx
added a commit
that referenced
this pull request
Dec 20, 2017
The last operation executed in IndicesClientDocumentationIT.testCreate() is an asynchronous index creation. Because nothing waits for its completion, on slow machines the index can sometimes be created after the testCreate() test is finished, and it can fail the following test. Closes #27754
tlrx
added a commit
that referenced
this pull request
Dec 20, 2017
The last operation executed in IndicesClientDocumentationIT.testCreate() is an asynchronous index creation. Because nothing waits for its completion, on slow machines the index can sometimes be created after the testCreate() test is finished, and it can fail the following test. Closes #27754
|
Thanks @dnhatn ! |
martijnvg
added a commit
that referenced
this pull request
Dec 21, 2017
* es/master: (45 commits) Adapt scroll rest test after backport. relates #27842 Move early termination based on index sort to TopDocs collector (#27666) Upgrade beats templates that we use for bwc testing. (#27929) ingest: upgraded ingest geoip's geoip2's dependencies. [TEST] logging for update by query test #27820 Add elasticsearch-nio jar for base nio classes (#27801) Use full profile on JDK 10 builds Require Gradle 4.3 Enable grok processor to support long, double and boolean (#27896) Add unreleased v6.1.2 version TEST: reduce blob size #testExecuteMultipartUpload Check index under the store metadata lock (#27768) Fixes DocStats to not report index size < -1 (#27863) Fixed test to be up to date with the new database files. Upgrade to Lucene 7.2.0. (#27910) Disable TestZenDiscovery in cloud providers integrations test Use `_refresh` to shrink the version map on inactivity (#27918) Make KeyedLock reentrant (#27920) ingest: Upgraded the geolite2 databases. [Test] Fix IndicesClientDocumentationIT (#27899) ...
martijnvg
added a commit
that referenced
this pull request
Dec 21, 2017
* es/6.x: (43 commits) ingest: upgraded ingest geoip's geoip2's dependencies. [TEST] logging for update by query test #27820 Use full profile on JDK 10 builds Require Gradle 4.3 Add unreleased v6.1.2 version TEST: reduce blob size #testExecuteMultipartUpload Check index under the store metadata lock (#27768) Upgrade to Lucene 7.2.0. (#27910) Fixed test to be up to date with the new database files. Use `_refresh` to shrink the version map on inactivity (#27918) Make KeyedLock reentrant (#27920) Fixes DocStats to not report index size < -1 (#27863) Disable TestZenDiscovery in cloud providers integrations test ingest: Upgraded the geolite2 databases. [Issue-27716]: CONTRIBUTING.md IntelliJ configurations settings are confusing. (#27717) [Test] Fix IndicesClientDocumentationIT (#27899) Move uid lock into LiveVersionMap (#27905) Mute testRetentionPolicyChangeDuringRecovery Increase Gradle heap space to 1536m Move GlobalCheckpointTracker and remove SequenceNumbersService (#27837) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last operation executed in
IndicesClientDocumentationIT.testCreate()is an asynchronous index creation. Because nothing waits for its
completion, on slow machines the index can sometimes be created after
the
testCreate()test is finished and it can fail the following test.This pull request adds some
assertBusyloops in order to wait for thecompletion of async operations.
Closes #27754