Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated percolator map_unmapped_fields_as_string setting #28060

Conversation

martijnvg
Copy link
Member

No description provided.

@martijnvg martijnvg added :Search Relevance/Percolator Reverse search: find queries that match a document >breaking review v7.0.0 labels Jan 3, 2018
@martijnvg martijnvg force-pushed the remove_percolator_map_unmapped_fields_as_string_setting branch from c357fff to 1d35b53 Compare January 3, 2018 11:20
@jpountz
Copy link
Contributor

jpountz commented Jan 24, 2018

Silly question: since it is just a rename of the setting, can it be done automatically for users upon upgrade?

@martijnvg
Copy link
Member Author

@jpountz I think we need to have infrastructure for this? Otherwise it will require additional custom code in percolator to achieve that.

Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I see the old setting had been deprecated for some time now. It works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search Relevance/Percolator Reverse search: find queries that match a document v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants