Java api clean up: remove deprecated isShardsAcked
#28311
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Thanks, looks good. I just checked similar removals in 6.0 and saw that we tend to include changes like this to the client facing Java API in the migration docs. You seem to have done something similar already in #23923. Could you add a new java.asciidoc" file to docs/reference/migration/migrate_7_0` similar like we have it on the 6.0 branch (also include it in migrate_7_0.asciidoc index file) and add a short comment about this removal and the new method there.
|
@cbuescher nice catch ;) I just added a short note. |
| @@ -31,6 +31,7 @@ Elasticsearch 6.x in order to be readable by Elasticsearch 7.x. | |||
| * <<breaking_70_plugins_changes>> | |||
| * <<breaking_70_analysis_changes>> | |||
| * <<breaking_70_api_changes>> | |||
| * <<breaking_70_java_changes>> | |||
There was a problem hiding this comment.
One small thing to add: the following section needs to include the java:asciidoc you added, otherwise the link cannot be resolved.
|
@olcbean thanks, one more small thing to add, other than that this looks ready to me. |
|
Sorry about that :( Now should be better. |
|
@olcbean great, going to merge this soon |
* master: (23 commits) Update Netty to 4.1.16.Final (elastic#28345) Fix peer recovery flushing loop (elastic#28350) REST high-level client: add support for exists alias (elastic#28332) REST high-level client: move to POST when calling API to retrieve which support request body (elastic#28342) Add Indices Aliases API to the high level REST client (elastic#27876) Java Api clean up: remove deprecated `isShardsAcked` (elastic#28311) [Docs] Fix explanation for `from` and `size` example (elastic#28320) Adapt bwc version after backport elastic#28358 Always return the after_key in composite aggregation response (elastic#28358) Adds test name to MockPageCacheRecycler exception (elastic#28359) Adds a note in the `terms` aggregation docs regarding pagination (elastic#28360) [Test] Fix DiscoveryNodesTests.testDeltas() (elastic#28361) Update packaging tests to work with meta plugins (elastic#28336) Remove Painless Type from MethodWriter in favor of Java Class. (elastic#28346) [Doc] Fixs typo in reverse-nested-aggregation.asciidoc (elastic#28348) Reindex: Shore up rethrottle test Only assert single commit iff index created on 6.2 isHeldByCurrentThread should return primitive bool [Docs] Clarify `html` encoder in highlighting.asciidoc (elastic#27766) Fix GeoDistance query example (elastic#28355) ...
This PR removes previously deprecated
isShardsAckedRelated to #27784
Follow-up of #27819