Remove Painless Type from e-nodes in favor of Java Class #28364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
approved these changes
Jan 24, 2018
| public static Class<?> TypeToClass (Type type) { | ||
| if (type.dynamic) { | ||
| public static Class<?> TypeToClass(Type type) { | ||
| if ("def".equals(type.struct.name)) { |
There was a problem hiding this comment.
Maybe use def.class.getShortName()?
There was a problem hiding this comment.
Updated for all of Definition.
|
@rjernst Thanks for the review. Will commit as soon as CI completes. |
jdconrad
added a commit
that referenced
this pull request
Jan 29, 2018
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fourth part in a series to remove Painless Type. This replaces Painless Type with Java Class for all expression type nodes in Painless. This is a somewhat large change because the base node for all expression nodes is modified and can't really be broken up.