Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Painless Type From Locals, Variables, Params, and ScriptInfo #28471

Merged
merged 2 commits into from
Feb 1, 2018
Merged

Remove Painless Type From Locals, Variables, Params, and ScriptInfo #28471

merged 2 commits into from
Feb 1, 2018

Conversation

jdconrad
Copy link
Contributor

@jdconrad jdconrad commented Feb 1, 2018

Removes Painless Type in favor of Java Class from Locals, Variables, Params, and ScriptInfo.

@jdconrad jdconrad requested a review from rjernst February 1, 2018 01:22
rjernst
rjernst approved these changes Feb 1, 2018
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdconrad jdconrad merged commit df1c696 into elastic:master Feb 1, 2018
@jdconrad
Copy link
Contributor Author

jdconrad commented Feb 1, 2018

@rjernst Thanks for the review!

jdconrad added a commit that referenced this pull request Feb 1, 2018
@jdconrad
Remove Painless Type From Locals, Variables, Params, and ScriptInfo (#…
f75f32f 
…28471)
@clintongormley clintongormley added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache and removed :Plugin Lang Painless labels Feb 14, 2018
@jdconrad jdconrad mentioned this pull request May 31, 2018
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjernst rjernst rjernst approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >non-issue v6.3.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jdconrad @rjernst @clintongormley @colings86 @jpountz