Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow _update and upsert to read from the transaction log #29264

Merged
merged 5 commits into from
Mar 28, 2018

Commits on Mar 27, 2018

  1. Allow _update and upsert to read from the transaction log

    We historically removed reading from the transaction log to get consistent
    results from _GET calls. There was also the motivation that the read-modify-update
    principle we apply should not be hidden from the user. We still agree on the fact
    that we should not hide these aspects but the impact on updates is quite significant
    especially if the same documents is updated before it's written to disk and made serachable.
    
    This change adds back the ability to read from the transaction log but only for update calls.
    Calls to the _GET API will always do a refresh if necessary to return consistent results ie.
    if stored fields or DocValues Fields are requested.
    s1monw committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    a8d3b73 View commit details
    Browse the repository at this point in the history
  2. apply feedback from @jpountz

    s1monw committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    3fa0fc0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    41a3c32 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. apply feedback from @ywelch

    s1monw committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    3b84354 View commit details
    Browse the repository at this point in the history
  2. add annontation

    s1monw committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    5be76c5 View commit details
    Browse the repository at this point in the history