Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuation_indent_size #29440

Closed
wants to merge 1 commit into from
Closed

Add continuation_indent_size #29440

wants to merge 1 commit into from

Conversation

Van0SS
Copy link
Contributor

@Van0SS Van0SS commented Apr 10, 2018

I spent several hours figuring out why Intellij IDEA uses Continuation Indent 4 spaces even if I change size directly in the project settings. Turned out that I had EditorConfig plugin enabled which picks up .editorconfig and override all the project settings. But the problem is that it sets Continuation Indent the same as indent_size, which is completely wrong. To fix it Plugin's authors added custom property continuation_indent_size. This property is supported only by IDEA but should not bring any harm for other IDEs.

Intellij IDEA's EditorConfig plugin set Continuation Indent the same as `indent_size`. It can be fixed if add `continuation_indent_size` propery.
@cbuescher cbuescher added the :Delivery/Build Build or test infrastructure label Apr 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@javanna
Copy link
Member

javanna commented May 7, 2018

@elastic/es-core-infra thoughts on this one?

@javanna
Copy link
Member

javanna commented Aug 16, 2018

ping @elastic/es-core-infra do we want to get this one in? Thoughts?

@rjernst rjernst removed the review label Oct 10, 2018
@danielmitterdorfer
Copy link
Member

Thank you very much for taking the time and addressing this. I have tested this in IntelliJ IDEA 2018.3 (Community Edition), Build #IC-183.4284.148 and the bundled EditorConfig plugin and unfortunately this setting seems to be ineffective.

Evidence I am basing my assessment on:

  • As of today the referenced issue IDEA-145069 is still marked as "open".
  • If I add continuation_indent_size to .editorconfig it is reported as an unknown key.
  • If I enable "Parameter descriptions on new line" in the IDE configuration in Editor > Code Style > Java > JavaDoc(which according to the docs "uses indent based on the continuation indent value") and format a Javadoc snippet accordingly, it does not honor the continuation_indent_size I have defined in .editorconfig.

As such I hope you do not mind if we close this PR for the time being as the change is ineffective at the moment. If however, the underlying issue in the IDEA repository is fixed, we can definitely reopen this again.

@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants