Fix missing node id prefix in startup logs #29534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `node.name` is not set, some log traces at startup time does not show the node id.
tlrx
added
review
:Core/Infra/Logging
DaveCTurner
reviewed
Apr 16, 2018
There was a problem hiding this comment.
Good plan! Shame about the first initializing ... line :)
Does it make sense to remove the node name from this message, since it now appears twice?
[2018-04-16T16:02:14,848][INFO ][o.e.n.Node ] [P2NUhLl] node name [P2NUhLl] derived from node ID [P2NUhLlQTkmAHzlNM4HF2A]; set [node.name] to override
Well, at least it shows that the node.name is unknown when initializing the node. And it also respects the same log pattern :)
Yes, I removed it. Thanks for the review! |
hub-cap
added
:Core/Infra/Logging
|
Pinging @elastic/es-core-infra |
|
Thanks @DaveCTurner :) |
tlrx
added a commit
that referenced
this pull request
Apr 19, 2018
When `node.name` is not set, some log traces at startup time does not show the node id.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 19, 2018
* master: (21 commits) Remove bulk fallback for write thread pool (elastic#29609) Fix an incorrect reference to 'zero_terms_docs' in match_phrase queries. Update the version compatibility for zero_terms_query in match_phrase. Account translog location to ram usage in version map Remove extra spaces from changelog Add support to match_phrase query for zero_terms_query. (elastic#29598) Fix incorrect references to 'zero_terms_docs' in query parsing error messages. (elastic#29599) Build: Move java home checks to pre-execution phase (elastic#29548) Avoid side-effect in VersionMap when assertion enabled (elastic#29585) [Tests] Remove accidental logger usage Add tests for ranking evaluation with aliases (elastic#29452) Deprecate use of `htmlStrip` as name for HtmlStripCharFilter (elastic#27429) Update plan for the removal of mapping types. (elastic#29586) [Docs] Add rankEval method for Jva HL client Make ranking evaluation details accessible for client Rename the bulk thread pool to write thread pool (elastic#29593) [Test] Minor changes to rank_eval tests (elastic#29577) Fix missing node id prefix in startup logs (elastic#29534) Added painless execute api. (elastic#29164) test: also assert deprecation warning after clusters have been closed. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
node.nameis not set, some log traces at startup time does not show the node id. It does not look nice as some traces have the id and some others haven't:We can improve this a bit in order to make startup logs parsing easier (and to not hurt my eyes):