Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid side-effect in VersionMap when assertion enabled #29585

Merged
merged 8 commits into from
Apr 19, 2018
Merged

Avoid side-effect in VersionMap when assertion enabled #29585

merged 8 commits into from
Apr 19, 2018

Commits on Apr 18, 2018

  1. Avoid side-effect in VersionMap when assertion enabled 

    Today when a version map does not require safe access, we will skip that
document. However, if the assertion is enabled, we remove the delete
tombstone of that document if existed. This may accidentally hide bugs
in which stale delete tombstone can be accessed.

This change folds a tombstone map into the version map so that each
version map will have a separate tombstone map.
    @dnhatn
    dnhatn committed Apr 18, 2018
    Configuration menu
    Copy the full SHA
    81327ee View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2018

  1. Always put into the assert map

    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    4107caa View commit details
    Browse the repository at this point in the history

  2. Revert "Always put into the assert map" 

    This reverts commit 4107caa.
    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    32711aa View commit details
    Browse the repository at this point in the history

  3. Revert "Avoid side-effect in VersionMap when assertion enabled" 

    This reverts commit 81327ee.
    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    a7beda7 View commit details
    Browse the repository at this point in the history

  4. Untangle put index and put delete - Boaz’s suggestion

    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    0346ba6 View commit details
    Browse the repository at this point in the history

  5. inline getVersionValue method

    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    bec5ac3 View commit details
    Browse the repository at this point in the history

  6. Inline another test util method

    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    e2b9f96 View commit details
    Browse the repository at this point in the history

  7. Do no remove tombstone when safe-access not required

    @dnhatn
    dnhatn committed Apr 19, 2018
    Configuration menu
    Copy the full SHA
    516156a View commit details
    Browse the repository at this point in the history