Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 7.4.0-snapshot-8fdd3d7584 #30357

Merged
merged 7 commits into from
May 4, 2018
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/version.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
elasticsearch = 7.0.0-alpha1
lucene = 7.3.0
lucene = 7.4.0-snapshot-0c89db8425

# optional dependencies
spatial4j = 0.7
Expand Down
4 changes: 2 additions & 2 deletions docs/Versions.asciidoc
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
:version: 7.0.0-alpha1
:major-version: 7.x
:lucene_version: 7.3.0
:lucene_version_path: 7_3_0
:lucene_version: 7.4.0
:lucene_version_path: 7_4_0
:branch: master
:jdk: 1.8.0_131
:jdk_major: 8
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/*
* Licensed to Elasticsearch under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

package org.elasticsearch.analysis.common;

import org.apache.lucene.analysis.TokenStream;
import org.apache.lucene.analysis.miscellaneous.DisableGraphAttribute;
import org.apache.lucene.analysis.shingle.FixedShingleFilter;
import org.apache.lucene.analysis.shingle.ShingleFilter;
import org.elasticsearch.Version;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.env.Environment;
import org.elasticsearch.index.IndexSettings;
import org.elasticsearch.index.analysis.AbstractTokenFilterFactory;
import org.elasticsearch.index.analysis.TokenFilterFactory;

public class FixedShingleTokenFilterFactory extends AbstractTokenFilterFactory {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we will want to expose this token filter as it will introduce confusion as to whether this one should be used or the regular shingle filter. Let's keep this discussion to a follow-up and only tell the test to ignore this one for now? In my opinion it would remain an impl detail of the phrase query optimization for text fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ I realized afterward that we can just whitelist the missing factory.

private final int shingleSize;
private final String tokenSeparator;
private final String fillerToken;

public FixedShingleTokenFilterFactory(IndexSettings indexSettings, Environment environment, String name, Settings settings) {
super(indexSettings, name, settings);
this.shingleSize = settings.getAsInt("shingle_size", ShingleFilter.DEFAULT_MAX_SHINGLE_SIZE);
this.tokenSeparator = settings.get("token_separator", ShingleFilter.DEFAULT_TOKEN_SEPARATOR);
this.fillerToken = settings.get("filler_token", ShingleFilter.DEFAULT_FILLER_TOKEN);
}


@Override
public TokenStream create(TokenStream tokenStream) {
return new FixedShingleFilter(tokenStream, shingleSize, tokenSeparator, fillerToken);
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
2b4add2c5d9becd5196bb9b3f33498f9a8a8d1dc
2 changes: 1 addition & 1 deletion plugins/analysis-icu/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ forbiddenApis {

dependencies {
compile "org.apache.lucene:lucene-analyzers-icu:${versions.lucene}"
compile 'com.ibm.icu:icu4j:59.1'
compile 'com.ibm.icu:icu4j:61.1'
}

dependencyLicenses {
Expand Down
1 change: 0 additions & 1 deletion plugins/analysis-icu/licenses/icu4j-59.1.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions plugins/analysis-icu/licenses/icu4j-61.1.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
28d33b5e44e72edcc66a5da7a34a42147f38d987

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
c343d968621d0e450e7bc28a69067fd7a78fd679
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ private ICUTokenizerConfig getIcuConfig(Environment env, Settings settings) {
// cjkAsWords nor myanmarAsWords are not configurable yet.
ICUTokenizerConfig config = new DefaultICUTokenizerConfig(true, true) {
@Override
public BreakIterator getBreakIterator(int script) {
public RuleBasedBreakIterator getBreakIterator(int script) {
if (breakers[script] != null) {
return (BreakIterator) breakers[script].clone();
return (RuleBasedBreakIterator) breakers[script].clone();
} else {
return super.getBreakIterator(script);
}
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
719133476276d857cdcebbb65031b6822f6430f3

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
443864fe5b85adae4b2123364d202918d2702636

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
aa9c9b02b41e8e231648c2bbe7c4dd9a05957e73

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1cccb1582abf13bacc1508e4b79273fdda0d8ea7

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
7e7e979531ff207ad205fdb5ea6ff33ef616d793
1 change: 0 additions & 1 deletion server/licenses/lucene-analyzers-common-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
f70708cbdf3b6caca181e2e5062b7fecbc81a40f
1 change: 0 additions & 1 deletion server/licenses/lucene-backward-codecs-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
476ab849b429b28f87bbce9023c09cc26031e448
1 change: 0 additions & 1 deletion server/licenses/lucene-core-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
818c9e60452cc16963bedf66bdb1c33d2ab01c75
1 change: 0 additions & 1 deletion server/licenses/lucene-grouping-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
5458db127655d66e5d8886724b8aeb99da84e621
1 change: 0 additions & 1 deletion server/licenses/lucene-highlighter-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
12d55dac5dd58bf5d36a0633f5a70eb54d525df0
1 change: 0 additions & 1 deletion server/licenses/lucene-join-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
cb79ebfd3879a15b117619c674404573a9437cd3
1 change: 0 additions & 1 deletion server/licenses/lucene-memory-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
efb0a875d15a58035ce7fa483b15f9a8deb6ec79
1 change: 0 additions & 1 deletion server/licenses/lucene-misc-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
c8d27935b17351ee0636bb1ea34c1902d4da8041
1 change: 0 additions & 1 deletion server/licenses/lucene-queries-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ec48f8c323e7021249e9803a2a821cb5e2b28399
1 change: 0 additions & 1 deletion server/licenses/lucene-queryparser-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
51e27a3644618134c6524bbedc18ffd8b120ac95
1 change: 0 additions & 1 deletion server/licenses/lucene-sandbox-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
77129b009fc71779e0a07cf804da11b3025a9f45
1 change: 0 additions & 1 deletion server/licenses/lucene-spatial-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
e8cbf7a1ddf7263c2c0d43a7d18250912d5bd869
1 change: 0 additions & 1 deletion server/licenses/lucene-spatial-extras-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
d9fd22d61a148e597b5beb4e17a88660c39bcf5b
1 change: 0 additions & 1 deletion server/licenses/lucene-spatial3d-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
62dc45994535e75540278c8cc42099ddc21c2b2c
1 change: 0 additions & 1 deletion server/licenses/lucene-suggest-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
b291683bc0f30cddc4161070757135c7b4e4569d
2 changes: 1 addition & 1 deletion server/src/main/java/org/elasticsearch/Version.java
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ public class Version implements Comparable<Version>, ToXContentFragment {
public static final Version V_6_4_0 = new Version(V_6_4_0_ID, org.apache.lucene.util.Version.LUCENE_7_3_0);
public static final int V_7_0_0_alpha1_ID = 7000001;
public static final Version V_7_0_0_alpha1 =
new Version(V_7_0_0_alpha1_ID, org.apache.lucene.util.Version.LUCENE_7_3_0);
new Version(V_7_0_0_alpha1_ID, org.apache.lucene.util.Version.LUCENE_7_4_0);
public static final Version CURRENT = V_7_0_0_alpha1;

static {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ private static String toCamelCase(String s) {
.put("englishminimalstem", MovedToAnalysisCommon.class)
.put("englishpossessive", MovedToAnalysisCommon.class)
.put("finnishlightstem", MovedToAnalysisCommon.class)
.put("fixedshingle", MovedToAnalysisCommon.class)
.put("frenchlightstem", MovedToAnalysisCommon.class)
.put("frenchminimalstem", MovedToAnalysisCommon.class)
.put("galicianminimalstem", MovedToAnalysisCommon.class)
Expand Down
1 change: 0 additions & 1 deletion x-pack/plugin/sql/jdbc/licenses/lucene-core-7.3.0.jar.sha1

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
818c9e60452cc16963bedf66bdb1c33d2ab01c75

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
818c9e60452cc16963bedf66bdb1c33d2ab01c75