Packaging: Remove windows bin files from the tar distribution #30596
Conversation
This commit removes windows specific files from the tar distribution. Windows users use the zip, linux users use the tar.
rjernst
added
>breaking
:Delivery/Packaging
|
Pinging @elastic/es-core-infra |
rjernst
changed the title
|
My two cents: it would be surprising to me to find that the tgz and zip distributions had different contents. I do see how this makes sense though when considering file permission/attribute retention between the two formats. |
|
@andyb-elastic why is it not surprising then when rpm and deb don't also have these same contents? |
|
@rjernst It would not be reasonable for a Windows user to think that the RPM or Deb package is compatible with Windows. With the Linux subsystem and Git Bash, there are ways for a Windows user to easily consume a .tar.gz. Our download page does not give any indication that the .tar.gz is not compatible with Windows (and today it is compatible). Today we display the downloads as:
This is how the Kibana downloads appear:
And while Kibana has architecture-specific downloads (because of the Node binary), there is no confusion on Windows which artifact to download whereas there is possibility of confusion with our artifacts. I can support this change if we change our download page to indicate that the zip distribution is for Windows only and the .tar.gz is for macOS/Linux (and it needs to be macOS/Linux as we support these OS and no other Unix-like OS). |
|
Right, on Windows even without WSL, extracting the tgz with 7zip and running it seems to work fine and would be a pretty normal thing to do (at least I think). That said, I agree that making it explicit which platform these distributions are intended for is most helpful. Is the idea to take the bash scripts out of the zip distribution at some point as well? |
I would not be opposed to that. The only caveat is we would then need to select which distribution to use based on the system we are running tests on. And eg |
With each release we add the new download artifacts and their link contents, so this would need to be done with the 6.4.0 release (assuming this is merged to 6.x before 6.4 is cut). Is that sufficient? |
|
I am supportive of the proposed changes to the .tar.gz distribution.
Yes. |
|
Are there some major benefits in making the It will cause a certain amount of rework in @dolaru's QA test framework for ML, as currently this uses the |
|
just to be clear on what we're trying to achieve with this PR:
Also, when i say binaries i mean not just what's in is this right? |
|
This PR only changes the packaging content of the tar.gz distribution. It does not change the content of the zip distribution (there is discussion of it here), and it does not change the content of what executables are distributed under the ML module. |
|
Thanks for clarifying @jasontedor. I think making the |
|
Why are we making this change to the |
|
@sophiec20 There are multiple motivations here:
As Jason mentioned, this PR only removes the windows files from the tar.gz. To me, it is less important to remove the bash scripts from windows, since they will run on windows. That would not preclude labeling the zip and tar.gz files as windows and macos/linux though. |
* master: Add get stored script and delete stored script to high level REST API - post backport fix Add get stored script and delete stored script to high level REST API (#31355) Core: Combine Action and GenericAction (#31405) Fix reference to XContentBuilder.string() (#31337) Avoid sending duplicate remote failed shard requests (#31313) Fix defaults in GeoShapeFieldMapper output (#31302) RestAPI: Reject forcemerge requests with a body (#30792) Packaging: Remove windows bin files from the tar distribution (#30596) Docs: Use the default distribution to test docs (#31251) [DOCS] Adds testing for security APIs (#31345) Clarify that IP range data can be specified in CIDR notation. (#31374) Use system context for cluster state update tasks (#31241) Percentile/Ranks should return null instead of NaN when empty (#30460) REST high-level client: add validate query API (#31077) Move language analyzers from server to analysis-common module. (#31300) [Test] Fix :example-plugins:rest-handler on Windows Expose lucene's RemoveDuplicatesTokenFilter (#31275) Reload secure settings for plugins (#31383) Remove some cases in FieldTypeLookupTests that are no longer relevant. (#31381) Ensure we don't use a remote profile if cluster name matches (#31331) [TEST] Double write alias fault (#30942) [DOCS] Fix version in SQL JDBC Maven template [DOCS] Improve install and setup section for SQL JDBC SQL: Fix rest endpoint names in node stats (#31371) Support for remote path in reindex api - post backport fix Closes #22913 [ML] Put ML filter API response should contain the filter (#31362) Support for remote path in reindex api (#31290) Add byte array pooling to nio http transport (#31349) Remove trial status info from start trial doc (#31365) [DOCS] Adds links to release notes and highlights add is-write-index flag to aliases (#30942) Add rollover-creation-date setting to rolled over index (#31144) [ML] Hold ML filter items in sorted set (#31338) [Tests] Fix edge case in ScriptedMetricAggregatorTests (#31357)
This commit removes windows specific files from the tar distribution.
Windows users use the zip, linux users use the tar.