Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML][TEST] Make AutodetectMemoryLimitIT less fragile #30716

Merged
merged 1 commit into from
May 18, 2018
Merged

[ML][TEST] Make AutodetectMemoryLimitIT less fragile #30716

merged 1 commit into from
May 18, 2018

Commits on May 18, 2018

  1. [ML][TEST] Make AutodetectMemoryLimitIT less fragile 

    These tests aim to check the set model memory limit is
respected. Additionally, it was asserting counts of
partition, by, over fields in an attempt to check that
the used memory is spent meaningfully. However, this
made the tests fragile, as changes in the ml-cpp could
lead to CI failures.

This commit removes those assertions. We are working on
adding tests in ml-cpp that will compensate.
    @dimitris-athanasiou
    dimitris-athanasiou committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6b31fe2 View commit details
    Browse the repository at this point in the history