Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify state of VerifyRepositoryResponse for bwc #30762

Merged
merged 8 commits into from
May 22, 2018

Commits on May 21, 2018

  1. Modify state of VerifyRepositoryResponse for bwc

    The VerifyRepositoryResponse class holds a DiscoveryNode[], but the
    nodes themselves are not serialized to a REST API consumer. Since we do
    not want to put all of a DiscoveryNode over the wire, be it REST or
    Transport since its unused, this change introduces a BWC compatible
    change in ser/deser of the Response. Anything 6.4 and above will
    read/write a NodeView, and anything prior will read/write a
    DiscoveryNode. Further changes to 7.0 will be introduced to remove the
    BWC shim and only read/write NodeView, and hold a List<NodeView> as the
    VerifyRepositoryResponse internal state.
    hub-cap committed May 21, 2018
    Configuration menu
    Copy the full SHA
    6181534 View commit details
    Browse the repository at this point in the history
  2. Fixups as per review

    hub-cap committed May 21, 2018
    Configuration menu
    Copy the full SHA
    7761c26 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9b0967d View commit details
    Browse the repository at this point in the history
  4. Fix the assignment on nodes

    hub-cap committed May 21, 2018
    Configuration menu
    Copy the full SHA
    6790509 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2018

  1. Changes as per review

    hub-cap committed May 22, 2018
    Configuration menu
    Copy the full SHA
    75c2b73 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d59e05 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6d7dd78 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    383d761 View commit details
    Browse the repository at this point in the history