-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify signatures on official plugins #30800
Merged
jasontedor
merged 16 commits into
elastic:master
from
jasontedor:verify-official-plugin-signature
May 25, 2018
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
0d30e89
Verify signatures on official plugins
jasontedor a75d4a0
Adjust imports
jasontedor ea11c1a
Merge branch 'master' into verify-official-plugin-signature
jasontedor 22767a4
Fix regular expression
jasontedor ca53357
Inline method
jasontedor 62f5e93
Preserve comment
jasontedor c99106b
Put try on its own line
jasontedor f73c59b
Javadocs
jasontedor d95f2e9
Fix Windows plugin script
jasontedor 163e1c9
Fix unintended import changes
jasontedor 1f7b1ba
Fix typos
jasontedor 701d36a
Fix tools sub-dir
jasontedor a9350f3
Remove sout
jasontedor 50fdd05
Remove adding provider
jasontedor 9d40715
Merge branch 'master' into verify-official-plugin-signature
jasontedor ac911dc
Fix location
jasontedor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,16 +123,27 @@ Closure commonPackageConfig(String type, boolean oss) { | |
from(rootProject.projectDir) { | ||
include 'README.textile' | ||
} | ||
into('lib') { | ||
with copySpec { | ||
with libFiles | ||
// we need to specify every intermediate directory so we iterate through the parents; duplicate calls with the same part are fine | ||
eachFile { FileCopyDetails fcp -> | ||
String[] segments = fcp.relativePath.segments | ||
for (int i = segments.length - 2; i > 0 && segments[i] != 'lib'; --i) { | ||
System.out.println(segments[0..i]) | ||
directory('/' + segments[0..i].join('/'), 0755) | ||
} | ||
} | ||
} | ||
} | ||
into('modules') { | ||
with copySpec { | ||
with modulesFiles(oss) | ||
// we need to specify every intermediate directory, but modules could have sub directories | ||
// and there might not be any files as direct children of intermediates (eg platform) | ||
// so we must iterate through the parents, but duplicate calls with the same path | ||
// are ok (they don't show up in the built packages) | ||
// we need to specify every intermediate directory so we iterate through the parents; duplicate calls with the same part are fine | ||
eachFile { FileCopyDetails fcp -> | ||
String[] segments = fcp.relativePath.segments | ||
for (int i = segments.length - 2; i > 0 && segments[i] != 'modules'; --i) { | ||
System.out.println(segments[0..i]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. leftover println |
||
directory('/' + segments[0..i].join('/'), 0755) | ||
} | ||
} | ||
|
@@ -241,8 +252,8 @@ ospackage { | |
signingKeyId = project.hasProperty('signing.keyId') ? project.property('signing.keyId') : 'D88E42B4' | ||
signingKeyPassphrase = project.property('signing.password') | ||
signingKeyRingFile = project.hasProperty('signing.secretKeyRingFile') ? | ||
project.file(project.property('signing.secretKeyRingFile')) : | ||
new File(new File(System.getProperty('user.home'), '.gnupg'), 'secring.gpg') | ||
project.file(project.property('signing.secretKeyRingFile')) : | ||
new File(new File(System.getProperty('user.home'), '.gnupg'), 'secring.gpg') | ||
} | ||
|
||
requires('coreutils') | ||
|
@@ -253,7 +264,6 @@ ospackage { | |
permissionGroup 'root' | ||
|
||
into '/usr/share/elasticsearch' | ||
with libFiles | ||
with noticeFile | ||
} | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leftover println