-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames and refactoring for reloadable plugins #30992
Renames and refactoring for reloadable plugins #30992
Conversation
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not much to say, I looked at the renamings and it LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left a comment for something to handle in a followup.
* of the node's keystore (backing the implementation of | ||
* {@code SecureSettings}). | ||
*/ | ||
private String secureSettingsPassword; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we use a SecureString here? I know this is not anything new in this PR so we can handle in a follow up.
This handles some renames and javadocs for the reload-secure-store-action feature branch to deck it before merging to master. This is required because the scope of the branch was somewhat fluid, and as the work progressed, the names and comments were not illustrative for their purposes. This has mostly ornamental value but it does contains two refactorings, hence the encompassing PR title.
Here is the list with all renames:
All services that lend clients (
AwsS3Service
,AwsEc2Service
,GoogleCloudStorageService
andAzureStorageService
) have the methodsclient
andrefreshAndClearCache
. Thisclient
method creates (and cache) and returns a client (or a releasable wrapper). TherefreshAndClearCache
method updates the settings from which new clients are built and clears the cache of the old clients.Besides renames, there is one notable refactoring:
ReloadablePlugin#reload
now returns an exception on failure instead of a blandfalse
return value. This cascades back to the node response and how it deals with error handling.The other refactoring is that the method
releaseCachedClient
(forAwsS3Service
andAwsEc2Service
is now hidden and exposed throughCloseable#close
).Relates #29135