-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REST high-level client: add simulate pipeline API #31158
Merged
+1,182
−129
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e530bd4
Added simulate pipeline API
sohaibiftikhar 3497e0c
Fixes after review
sohaibiftikhar 1de794e
fixed integ test
sohaibiftikhar d08dcb5
Fixes after review (2)
sohaibiftikhar 755de50
Fixes after review (3)
sohaibiftikhar 54e7f6f
changed switch to if
sohaibiftikhar d8f5da9
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
sohaibiftikhar 64c9c51
Merge branch 'master' of https://github.com/elastic/elasticsearch int…
sohaibiftikhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -71,6 +71,7 @@ | |
import org.elasticsearch.action.ingest.DeletePipelineRequest; | ||
import org.elasticsearch.action.ingest.GetPipelineRequest; | ||
import org.elasticsearch.action.ingest.PutPipelineRequest; | ||
import org.elasticsearch.action.ingest.SimulatePipelineRequest; | ||
import org.elasticsearch.action.search.ClearScrollRequest; | ||
import org.elasticsearch.action.search.MultiSearchRequest; | ||
import org.elasticsearch.action.search.SearchRequest; | ||
|
@@ -1531,6 +1532,34 @@ public void testDeletePipeline() { | |
assertEquals(expectedParams, expectedRequest.getParameters()); | ||
} | ||
|
||
public void testSimulatePipeline() throws IOException { | ||
String pipelineId = randomBoolean() ? "some_pipeline_id" : null; | ||
boolean verbose = randomBoolean(); | ||
String json = "{\"pipeline\":{" + | ||
"\"description\":\"_description\"," + | ||
"\"processors\":[{\"set\":{\"field\":\"field2\",\"value\":\"_value\"}}]}," + | ||
"\"docs\":[{\"_index\":\"index\",\"_type\":\"_doc\",\"_id\":\"id\",\"_source\":{\"foo\":\"rab\"}}]}"; | ||
SimulatePipelineRequest request = new SimulatePipelineRequest( | ||
new BytesArray(json.getBytes(StandardCharsets.UTF_8)), | ||
XContentType.JSON | ||
); | ||
request.setId(pipelineId); | ||
request.setVerbose(verbose); | ||
Map<String, String> expectedParams = new HashMap<>(); | ||
expectedParams.put("verbose", Boolean.toString(verbose)); | ||
|
||
Request expectedRequest = RequestConverters.simulatePipeline(request); | ||
StringJoiner endpoint = new StringJoiner("/", "/", ""); | ||
endpoint.add("_ingest/pipeline"); | ||
if (pipelineId != null && !pipelineId.isEmpty()) | ||
endpoint.add(pipelineId); | ||
endpoint.add("_simulate"); | ||
assertEquals(endpoint.toString(), expectedRequest.getEndpoint()); | ||
assertEquals(HttpPost.METHOD_NAME, expectedRequest.getMethod()); | ||
assertEquals(expectedParams, expectedRequest.getParameters()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could you try it with a more realistic request body and assert on it at the end? |
||
assertToXContentBody(request, expectedRequest.getEntity()); | ||
} | ||
|
||
public void testClusterHealth() { | ||
ClusterHealthRequest healthRequest = new ClusterHealthRequest(); | ||
Map<String, String> expectedParams = new HashMap<>(); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that being this an integration test, we should randomize much less, if at all. We can have a fixed request and check that the response is expected, let's leave the randomizations for the unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also the test the case where you get back an error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shall we test the failure separately?