Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add note about removing prepareExecute from the java client #31401

Merged
merged 2 commits into from
Jun 19, 2018

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jun 18, 2018

relates #30966

@rjernst rjernst added >docs General docs changes :Core/Infra/Transport API Transport client API v7.0.0 labels Jun 18, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@rjernst
Copy link
Member Author

rjernst commented Jun 18, 2018

@elasticmachine run gradle build tests


The `prepareExecute` method which created a request builder has been
removed from the client api. Instead, construct a build for the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if this should be "builder" here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prepareExecute method returned a RequestBuilder. Is there something else you think it should be?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I see what you mean, thanks!

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javanna
Copy link
Member

javanna commented Jun 19, 2018

thanks @rjernst ! This was mainly used by modules and plugins given that for the methods supported by default we still have the prepare* methods around, right? That's what confused me in the original PR, maybe worth mentioning.

@rjernst
Copy link
Member Author

rjernst commented Jun 19, 2018

I think it would be confusing to mention the other prepareX methods, since they are unchanged.

@rjernst rjernst merged commit c0961b7 into elastic:master Jun 19, 2018
@rjernst rjernst deleted the deguice31_migration branch June 19, 2018 14:22
@javanna
Copy link
Member

javanna commented Jun 19, 2018

I didn't mean to mention unchanged bits, rather to explain clearly who may be impacted by this change (plugins devs rather than users)

dnhatn added a commit that referenced this pull request Jun 20, 2018
* master:
  [DOCS] Omit shard failures assertion for incompatible responses  (#31430)
  [DOCS] Move licensing APIs to docs (#31445)
  Add Delete Snapshot High Level REST API
  Remove QueryCachingPolicy#ALWAYS_CACHE (#31451)
  [Docs] Extend Homebrew installation instructions (#28902)
  Choose JVM options ergonomically
  [Docs] Mention ip_range datatypes on ip type page (#31416)
  Multiplexing token filter (#31208)
  Fix use of time zone in date_histogram rewrite (#31407)
  Core: Remove index name resolver from base TransportAction (#31002)
  [DOCS] Fixes code snippet testing for machine learning (#31189)
  [DOCS] Removed  and  params from MLT. Closes #28128 (#31370)
  Security: fix joining cluster with production license (#31341)
  Unify http channels and exception handling (#31379)
  [DOCS] Moves the info API to docs (#31121)
  Preserve response headers on cluster update task (#31421)
  [DOCS] Add code snippet testing for more ML APIs (#31404)
  Do not preallocate bytes for channel buffer (#31400)
  Docs: Advice for reindexing many indices (#31279)
  Mute HttpExporterTests#testHttpExporterShutdown test Tracked by #31433
  Docs: Add note about removing prepareExecute from the java client (#31401)
  Make release notes ignore the `>test-failure` label. (#31309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API >docs General docs changes v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants