Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure local addresses aren't null #31440

Merged
merged 13 commits into from
Jun 21, 2018

Commits on Jun 19, 2018

  1. Ensure local and remote addresses aren't null

    Currently we set local and remote addresses on the creation time of a
    NioChannel. However, these may return null as they may not have been
    set yet. An example is the local address has not been set on a client
    channels as the connection process is not yet complete.
    
    This PR modifies the getters to set the local and remote address fields
    if they are currently null.
    Tim-Brooks committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a391ffc View commit details
    Browse the repository at this point in the history
  2. A few cleanups

    Tim-Brooks committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a9af9a0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    22b0b58 View commit details
    Browse the repository at this point in the history
  4. Cleanups

    Tim-Brooks committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    ca09a53 View commit details
    Browse the repository at this point in the history
  5. Some more cleanups

    Tim-Brooks committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    a2a2874 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    20eca6f View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Throw as unchecked

    Tim-Brooks committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    e1caed3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    58aba13 View commit details
    Browse the repository at this point in the history
  3. Better propogate

    Tim-Brooks committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    a0599db View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    835cea8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3e2a2a5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ba1d5ee View commit details
    Browse the repository at this point in the history
  7. Fix tests

    Tim-Brooks committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    19498fd View commit details
    Browse the repository at this point in the history