-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure local addresses aren't null #31440
Merged
Merged
Commits on Jun 19, 2018
-
Ensure local and remote addresses aren't null
Currently we set local and remote addresses on the creation time of a NioChannel. However, these may return null as they may not have been set yet. An example is the local address has not been set on a client channels as the connection process is not yet complete. This PR modifies the getters to set the local and remote address fields if they are currently null.
Configuration menu - View commit details
-
Copy full SHA for a391ffc - Browse repository at this point
Copy the full SHA a391ffcView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9af9a0 - Browse repository at this point
Copy the full SHA a9af9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22b0b58 - Browse repository at this point
Copy the full SHA 22b0b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca09a53 - Browse repository at this point
Copy the full SHA ca09a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2a2874 - Browse repository at this point
Copy the full SHA a2a2874View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20eca6f - Browse repository at this point
Copy the full SHA 20eca6fView commit details
Commits on Jun 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for e1caed3 - Browse repository at this point
Copy the full SHA e1caed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58aba13 - Browse repository at this point
Copy the full SHA 58aba13View commit details -
Configuration menu - View commit details
-
Copy full SHA for a0599db - Browse repository at this point
Copy the full SHA a0599dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 835cea8 - Browse repository at this point
Copy the full SHA 835cea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e2a2a5 - Browse repository at this point
Copy the full SHA 3e2a2a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba1d5ee - Browse repository at this point
Copy the full SHA ba1d5eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 19498fd - Browse repository at this point
Copy the full SHA 19498fdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.