Reduce number of raw types warnings #31523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>non-issue
review
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
|
As an aside: figuring out why we have so many generic types (and reducing that number) is a different matter I think. |
rjernst
approved these changes
Jun 22, 2018
| @@ -688,6 +688,7 @@ public void testRealmLookupThrowingExceptionRest() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Why is this suppression still necessary (and the others in this file)?
There was a problem hiding this comment.
In this particular case L699 i.getArguments() returns an Object[] which needs to be cast to ActionListener. Some of the Mockito stuff in here also requires SupressWarnings but I haven't added it elsewhere to keep this PR focused in raw tapes removals. I also haven't removed some other warnings in the classes touched since I think its makes any clean-up PR like this harder to review.
Among the ~7000 warnings we currently have, raw type warnings are one of the biggest group (aprox. 1700) and one that is the easiest to reduce. This PR is a fist attempt to reduce this number, most of the time by using the unbounded wildcard.
cbuescher
force-pushed
the
reduce-rawTypes
branch
from
5eafe0b to
2a14945
Compare
Conflicts: server/src/test/java/org/elasticsearch/common/geo/BaseGeoParsingTestCase.java server/src/test/java/org/elasticsearch/common/geo/builders/AbstractShapeBuilderTestCase.java
|
I would not backport cleanups like this unless there is a compelling reason to do so. |
jasontedor
added a commit
to hub-cap/elasticsearch
that referenced
this pull request
Jun 25, 2018
* elastic/master: (92 commits) Reduce number of raw types warnings (elastic#31523) Migrate scripted metric aggregation scripts to ScriptContext design (elastic#30111) turn GetFieldMappingsResponse to ToXContentObject (elastic#31544) Close xcontent parsers (partial) (elastic#31513) Ingest Attachment: Upgrade Tika to 1.18 (elastic#31252) TEST: Correct the assertion arguments order (elastic#31540) Add get field mappings to High Level REST API Client (elastic#31423) [DOCS] Updates Watcher examples for code testing (elastic#31152) TEST: Add bwc recovery tests with synced-flush index [DOCS] Move sql to docs (elastic#31474) [DOCS] Move monitoring to docs folder (elastic#31477) Core: Combine doExecute methods in TransportAction (elastic#31517) IndexShard should not return null stats (elastic#31528) fix repository update with the same settings but different type (elastic#31458) Fix Mockito trying to mock IOException that isn't thrown by method (elastic#31433) (elastic#31527) Node selector per client rather than per request (elastic#31471) Core: Combine messageRecieved methods in TransportRequestHandler (elastic#31519) Upgrade to Lucene 7.4.0. (elastic#31529) [ML] Add ML filter update API (elastic#31437) Allow multiple unicast host providers (elastic#31509) ...
dnhatn
added a commit
that referenced
this pull request
Jun 26, 2018
* master: ingest: Add ignore_missing property to foreach filter (#22147) (#31578) Fix a formatting issue in the docvalue_fields documentation. (#31563) reduce log level at gradle configuration time [TEST] Close additional clients created while running yaml tests (#31575) Docs: Clarify sensitive fields watcher encryption (#31551) Watcher: Remove never executed code (#31135) Add support for switching distribution for all integration tests (#30874) Improve robustness of geo shape parser for malformed shapes (#31449) QA: Create xpack yaml features (#31403) Improve test times for tests using `RandomObjects::addFields` (#31556) [Test] Add full cluster restart test for Rollup (#31533) Enhance thread context uniqueness assertion [DOCS] Fix heading format errors (#31483) fix writeIndex evaluation for aliases (#31562) Add x-opaque-id to search slow logs (#31539) Watcher: Fix put watch action (#31524) Add package pre-install check for java binary (#31343) Reduce number of raw types warnings (#31523) Migrate scripted metric aggregation scripts to ScriptContext design (#30111) turn GetFieldMappingsResponse to ToXContentObject (#31544) Close xcontent parsers (partial) (#31513) Ingest Attachment: Upgrade Tika to 1.18 (#31252) TEST: Correct the assertion arguments order (#31540)
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 4, 2018
Similar to elastic#31523.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among the ~7000 warnings we currently have, raw type warnings are one of the biggest
group (aprox. 1700) and one that is the easiest to reduce, I think. This PR is a first attempt
to reduce this number, most of the time by using the unbounded wildcard.