Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Randomize soft-deletes settings #31585

Merged
merged 5 commits into from
Jun 29, 2018

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jun 26, 2018

This change allows us to test our system with/without soft-deletes enabled.

This change allows us to test our system with/without soft-deletes enabled.
@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features labels Jun 26, 2018
@dnhatn dnhatn requested a review from bleskes June 26, 2018 17:44
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@bleskes bleskes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI is happy. Also please run for a good day on your CI before merging. I don't think one successful CI run is enough for this one.

@dnhatn
Copy link
Member Author

dnhatn commented Jun 29, 2018

testAuthenticateCaching failed.

@elasticmachine test this please.

@dnhatn
Copy link
Member Author

dnhatn commented Jun 29, 2018

It passed several iterations on my CI. I will merge this and watch the CCR builds. Thanks @bleskes.

@dnhatn dnhatn merged commit 540da73 into elastic:ccr Jun 29, 2018
@dnhatn dnhatn deleted the random-soft-deletes-setting branch June 29, 2018 21:35
jasontedor added a commit to martijnvg/elasticsearch that referenced this pull request Jul 1, 2018
* elastic/ccr: (30 commits)
  Enable setting client path prefix to / (elastic#30119)
  [DOCS] Secure settings specified per node (elastic#31621)
  has_parent builder: exception message/param fix (elastic#31182)
  TEST: Randomize soft-deletes settings (elastic#31585)
  Mute 'Test typed keys parameter for suggesters' as we await a fix.
  Build test: Thread linger
  Fix gradle4.8 deprecation warnings (elastic#31654)
  Mute FileRealmTests#testAuthenticateCaching with an @AwaitsFix.
  Mute TransportChangePasswordActionTests#testIncorrectPasswordHashingAlgorithm with an @AwaitsFix.
  Build: Fix naming conventions task   (elastic#31681)
  Introduce a Hashing Processor (elastic#31087)
  Do not check for object existence when deleting repository index files (elastic#31680)
  Remove extra check for object existence in repository-gcs read object (elastic#31661)
  Support multiple system store types (elastic#31650)
  [Test] Clean up some repository-s3 tests (elastic#31601)
  [Docs] Use capital letters in section headings (elastic#31678)
  muted tests that will be replaced by the shard follow task refactoring: elastic#31581
  [DOCS] Add PQL language Plugin (elastic#31237)
  Merge AzureStorageService and AzureStorageServiceImpl and clean up tests (elastic#31607)
  TEST: Fix test task invocation (elastic#31657)
  ...
dnhatn added a commit that referenced this pull request Aug 2, 2018
This change allows us to test our system with/without soft-deletes enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants