[ML] add duration statistics to forecast stats #31812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
davidkyle
reviewed
Jul 5, 2018
| @@ -1135,6 +1137,9 @@ public void getForecastStats(String jobId, Consumer<ForecastStats> handler, Cons | |||
| .field(ForecastRequestStats.PROCESSED_RECORD_COUNT.getPreferredName())); | |||
| sourceBuilder.aggregation( | |||
| AggregationBuilders.stats(ForecastStats.Fields.RUNTIME).field(ForecastRequestStats.PROCESSING_TIME_MS.getPreferredName())); | |||
| Script durationScript = new Script("doc['" + ForecastRequestStats.END_TIME + "'].value.getMillis() - doc['" | |||
There was a problem hiding this comment.
It would be nice to have test coverage of this. There is a JobProviderIT class could you index some forecast stats in that and assert this method.
|
As Closing this PR for now. I will follow up off-line regarding alternatives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is an extension to #31647 adding duration to the statistics.
Notes:
duration_msignores the status of the forecasts, so includes failed ones as well. So it is rather statistics about the durations that have been requested